Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new buildifier issues #1162

Merged
merged 1 commit into from Aug 23, 2023
Merged

Fix new buildifier issues #1162

merged 1 commit into from Aug 23, 2023

Conversation

mlw
Copy link
Member

@mlw mlw commented Aug 23, 2023

Addresses buildifier issues that suddenly started.

Example: https://github.com/google/santa/actions/runs/5953025386/job/16146336259?pr=1161

@mlw mlw added the cleanup label Aug 23, 2023
@mlw mlw requested a review from a team as a code owner August 23, 2023 15:02
pmarkowsky
pmarkowsky approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mlw mlw merged commit 4d0af88 into google:main Aug 23, 2023
9 checks passed
@pmarkowsky pmarkowsky added this to the 2023.8 Release milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmarkowsky pmarkowsky pmarkowsky approved these changes

Assignees
No one assigned
Labels
build cleanup
Projects
None yet
Milestone
2023.8 Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mlw @pmarkowsky