Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record metrics for device manager startup operations #1218

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Record metrics for device manager startup operations #1218

merged 3 commits into from
Nov 3, 2023

Conversation

mlw
Copy link
Member

@mlw mlw commented Nov 2, 2023

Records the system's startup preference value, as well as the operation performed for each USB device found during startup.

Example:

  Metric Name               | /santa/device_manager/startup_preference
  Description               | The current startup preference value
  Type                      | SNTMetricTypeGaugeInt64
  Created                   | 2023-11-02T19:36:25.162Z
  Last Updated              | 2023-11-02T19:36:28.983Z
  Data                      | 3

  Metric Name               | /santa/device_manager/startup_disk_operation
  Description               | Count of the number of USB devices encountered per operation
  Type                      | SNTMetricTypeCounter
  Field                     | operation=Skipped
  Created                   | 2023-11-02T19:35:02.527Z
  Last Updated              | 2023-11-02T19:35:02.528Z
  Data                      | 11
  Field                     | operation=Success
  Created                   | 2023-11-02T19:35:04.657Z
  Last Updated              | 2023-11-02T19:35:04.657Z
  Data                      | 1

@mlw mlw added metrics Code / work related to Santa observability / monitoring santad Work related to the Santa Daemon labels Nov 2, 2023
@mlw mlw requested a review from a team as a code owner November 2, 2023 19:46
pmarkowsky
pmarkowsky approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mlw mlw merged commit f9a937a into google:main Nov 3, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmarkowsky pmarkowsky pmarkowsky approved these changes

Assignees
No one assigned
Labels
metrics Code / work related to Santa observability / monitoring santad Work related to the Santa Daemon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mlw @pmarkowsky