Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test issue caused by move to C++20 #1245

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Fix test issue caused by move to C++20 #1245

merged 4 commits into from
Nov 29, 2023

Conversation

mlw
Copy link
Member

@mlw mlw commented Nov 29, 2023

No description provided.

@mlw mlw added this to the 2023.10 Release milestone Nov 29, 2023
@mlw mlw requested a review from a team as a code owner November 29, 2023 21:15
pmarkowsky
pmarkowsky previously approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

kallsyms
kallsyms previously approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@kallsyms kallsyms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👾

pmarkowsky
pmarkowsky previously approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mlw mlw enabled auto-merge (squash) November 29, 2023 21:51
@mlw mlw merged commit c16f90f into google:main Nov 29, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kallsyms kallsyms kallsyms approved these changes

@pmarkowsky pmarkowsky pmarkowsky left review comments

Assignees
No one assigned
Labels
bug testing
Projects
None yet
Milestone
2023.10 Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mlw @pmarkowsky @kallsyms