Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert back to C++17 for now #1246

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Revert back to C++17 for now #1246

merged 1 commit into from
Nov 30, 2023

Conversation

mlw
Copy link
Member

@mlw mlw commented Nov 30, 2023

Due to internal reasons, we need to continue on C++17 for now.

@mlw mlw added the build label Nov 30, 2023
@mlw mlw added this to the 2023.10 Release milestone Nov 30, 2023
@mlw mlw requested a review from a team as a code owner November 30, 2023 02:22
pmarkowsky
pmarkowsky approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mlw mlw merged commit 2b5d557 into google:main Nov 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russellhancox russellhancox russellhancox approved these changes

@pmarkowsky pmarkowsky pmarkowsky approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
2023.10 Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mlw @russellhancox @pmarkowsky