Add back support for EnableForkAndExitLogging config key #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlw
force-pushed
the
config-fork-exec-logging
branch
from
9271197
to
b2ecc38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds back support for this configuration key that was inadvertently removed in v2022.9.
The default value is meant to be
false. However since v2022.9, this value has effectively been hardcoded totrue. This change fixes the logic back to the original intention.IMPORTANT: This means that if you want
FORK/EXITevents to continue to be logged, you must set theEnableForkAndExitLoggingconfig key totrueFixes #1269