Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect fail closed on deadlines #1285

Merged
merged 5 commits into from Feb 8, 2024

Conversation

mlw
Copy link
Member

@mlw mlw commented Feb 8, 2024

Santa attempts to respond to events before system deadlines in case event processing took too long for some reason. This previously only resulted in events being denied.

This PR changes two things related to the default respons Santa will make before deadlines expire:

  1. When in Lockdown mode, FailClosed configuration will now be respected
  2. When in Monitor mode, Santa will ALLOW the events

Fixes #1283

@mlw mlw added enhancement santad Work related to the Santa Daemon configurator labels Feb 8, 2024
@mlw mlw requested a review from a team as a code owner February 8, 2024 16:01
kallsyms
kallsyms previously approved these changes Feb 8, 2024
russellhancox
russellhancox previously approved these changes Feb 8, 2024
@mlw mlw merged commit 64e81be into google:main Feb 8, 2024
10 checks passed
@mlw mlw added this to the 2024.2 milestone Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configurator enhancement santad Work related to the Santa Daemon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deadline exceeded in monitor mode still ends up denying execution
3 participants