Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Restore default button type to MessageWindow for blocked events #1316

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Conversation

radsec
Copy link
Contributor

@radsec radsec commented Mar 26, 2024

[Bug] Restore default button type to MessageWindow for blocked events

CONTEXT

At some point in macOS 14 with the latest few agent revisions, the MessageWindow needs a hidden titlebar in order for the default button to show.

This is more of a stop-gap measure until this can be rewritten in SwiftUI, which I don't mind taking in the coming weeks to help contribute that change back.
@russellhancox --> #1006 --> I can probs take the MessageWindow in the coming weeks.

For now, this UI bug can be quickly restored without much effort and decrease UX issues/confusion reported from our users.

CHANGES

TESTING

  • from latest dev/main branch
Screenshot 2024-03-25 at 15 28 48

@radsec radsec requested a review from a team as a code owner March 26, 2024 16:59
@russellhancox russellhancox self-assigned this Mar 28, 2024
@russellhancox
Copy link
Collaborator

This is more of a stop-gap measure until this can be rewritten in SwiftUI, which I don't mind taking in the coming weeks to help contribute that change back.

If you have the time and inclination, have at it, we'd appreciate it! I ran into issues trying to get all the various field and buttons to align properly with SwiftUI in a way that matches the current dialog (e.g. some fields aren't always populated and the "Open" button doesn't always exist, but we still want the UI to look consistent and centered in those cases) so I put it down and moved on to other things.

@radsec
Copy link
Contributor Author

radsec commented Mar 28, 2024

This is more of a stop-gap measure until this can be rewritten in SwiftUI, which I don't mind taking in the coming weeks to help contribute that change back.

If you have the time and inclination, have at it, we'd appreciate it! I ran into issues trying to get all the various field and buttons to align properly with SwiftUI in a way that matches the current dialog (e.g. some fields aren't always populated and the "Open" button doesn't always exist, but we still want the UI to look consistent and centered in those cases) so I put it down and moved on to other things.

good to know and thanks for the heads up on this.

@russellhancox russellhancox merged commit 3b2d02f into google:main Mar 28, 2024
9 checks passed
@russellhancox
Copy link
Collaborator

Thanks for the contribution!

@pmarkowsky pmarkowsky added this to the 2024.4 milestone Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants