Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an extra return on the rename case #570

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Add an extra return on the rename case #570

merged 1 commit into from
Aug 12, 2021

Conversation

tnek
Copy link
Contributor

@tnek tnek commented Aug 12, 2021

Missed handling the fallthrough from #569.

This should've been caught by a linter, will add that to our CI in a followup PR

@tnek tnek requested a review from pmarkowsky August 12, 2021 17:46
@google-cla google-cla bot added the cla: yes label Aug 12, 2021
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tnek tnek merged commit ac1f8ea into google:main Aug 12, 2021
@tnek tnek deleted the fallthrough branch August 13, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants