Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable -Werror -Wall on our build rules #572

Merged
merged 6 commits into from
Aug 13, 2021
Merged

Enable -Werror -Wall on our build rules #572

merged 6 commits into from
Aug 13, 2021

Conversation

tnek
Copy link
Contributor

@tnek tnek commented Aug 12, 2021

This PR enables -Werror -Wall on our build rules and fixes the following warnings:

  • Corrected signed/unsigned int conversions in SNTPrefixTree and Santacache
  • Nullability annotations to the rest of EndpointSecurityTestUtil
  • Reorder init lists in SNTEndpointSecurityManagerTest and SNTApplicationTest
  • Add annotations for "unused" (actually used) variables in SNTEndpointSecurityManagerTest

This should bring us in-line with internal warnings.

@tnek tnek added the cleanup label Aug 12, 2021
@google-cla google-cla bot added the cla: yes label Aug 12, 2021
@tnek tnek linked an issue Aug 12, 2021 that may be closed by this pull request
Add more linting rules and warnings #571
Closed
@pmarkowsky pmarkowsky self-assigned this Aug 13, 2021
pmarkowsky
pmarkowsky approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tnek tnek merged commit 1edf6d9 into google:main Aug 13, 2021
@tnek tnek deleted the linters2 branch August 22, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmarkowsky pmarkowsky pmarkowsky approved these changes

@tburgin tburgin Awaiting requested review from tburgin

Assignees

@pmarkowsky pmarkowsky

Labels
cla: yes cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more linting rules and warnings
2 participants
@tnek @pmarkowsky