Remove use of entitlements field for the santad build rule #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmarkowsky
previously approved these changes
Sep 28, 2021
There was a problem hiding this comment.
LGTM, but seems like a good time to wait for @russellhancox or @tburgin to chime in, in case we've missed something with the greater build pipeline.
… sudo from most of the build stages
russellhancox
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert entitlements change and update the codesign behavior of
Testing/build_and_sign.shto match that of the internal kokorosign.sh.I misunderstood how our release workflow worked when testing for if #602 broke anything - as it turns out, our .provisionfile isn't actually used in the release build and we instead use separate keys and the entitlements file, where the actual
codesigntool fills in TeamIdentifierPrefix. The entitlements arg for the build rule can't nicely fill this in, so remove it for now and instead mirror the kokoro sign.sh behavior within external build_and_sign.sh.