Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a USB device blocking popup. #728

Merged
merged 13 commits into from
Feb 28, 2022
Merged

Add a USB device blocking popup. #728

merged 13 commits into from
Feb 28, 2022

Conversation

tnek
Copy link
Contributor

@tnek tnek commented Feb 10, 2022

  • Refactor SNTNotificationManager and SNTMessageWindowController for generalized notification logic
  • Add the following popup:

image

* Refactor SNTNotificationManager and SNTMessageWindowController to make
  for generalized notification logic
@tnek tnek added this to the 2022.2 Release milestone Feb 11, 2022
@russellhancox
Copy link
Collaborator

I haven't had a chance to look at the code yet but from the screenshot I have a few immediate comments:

  1. Can the message shown be customized or can a custom message be added on the window? This can be useful for admins to point users at company specific documentation for the messages.
  2. Can the remount permissions have "human readable" conversions added?
  3. Can we remove the large amount of empty space between the event details and the OK button?
  4. Can the OK button be centered horizontally?

@tnek
Copy link
Contributor Author

tnek commented Feb 15, 2022

Done. They'll be configurable with the BannedUSBBlockMessage and RemountUSBBlockMessage configurator keys. Here's what these prompts look like now:

I'm struggling with phrasing for human-readable conversions of the remount permissions, if you have ideas for what's clearest for users.

Screen Shot 2022-02-15 at 3 22 33 PM
Screen Shot 2022-02-15 at 2 58 55 PM

Source/santad/SNTApplication.m Outdated Show resolved Hide resolved
Source/common/SNTDeviceEvent.h Show resolved Hide resolved
@tnek tnek merged commit c7e309c into google:main Feb 28, 2022
@tnek tnek deleted the blocknotify branch February 28, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants