Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Santa kernel extension. #749

Merged
merged 8 commits into from
Mar 14, 2022
Merged

Remove the Santa kernel extension. #749

merged 8 commits into from
Mar 14, 2022

Conversation

tnek
Copy link
Contributor

@tnek tnek commented Mar 14, 2022

This PR removes:

  • All of the code in Source/santa_driver containing the kernel extension
  • The SNTDriverManager event provider
  • All workflows in our CI related to testing if the driver builds
  • Installation of the driver in install.sh. Note that code uninstalling existing instances of the driver is still intentionally kept present.
  • Kernel extension-specific build rules
  • Renames SNTKernelCommon to SNTCommon
  • Driver version output from santactl version
  • The [SNTConfigurator EnableSystemExtension] configuration key

@tnek tnek requested a review from mlw March 14, 2022 20:45
@tnek tnek added the cleanup label Mar 14, 2022
@tnek tnek added this to the 2022.3 Release milestone Mar 14, 2022
russellhancox
russellhancox previously approved these changes Mar 14, 2022
@tnek
Copy link
Contributor Author

tnek commented Mar 14, 2022

Caught a few other references to SNTDriverManager to remove that was breaking tests. PTAL, this required rewriting parts of a few unit tests to mock an abstract implementation of the EventProvider protocol instead of the more concrete SNTDriverManager class.

@tnek tnek requested a review from russellhancox March 14, 2022 21:32
Source/santactl/BUILD Outdated Show resolved Hide resolved
Source/common/BUILD Outdated Show resolved Hide resolved
Source/santad/SNTApplication.m Show resolved Hide resolved
Source/santad/main.m Outdated Show resolved Hide resolved
@tnek tnek merged commit 211dbd1 into google:main Mar 14, 2022
@tnek tnek deleted the deprecatekext branch March 14, 2022 22:17
@pmarkowsky
Copy link
Contributor

This is the bulk of the work for #738.

Still need to remove the enums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants