Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model identifier to preflight request #751

Merged

Conversation

np5
Copy link
Contributor

@np5 np5 commented Mar 15, 2022

This is something that could help us identify some machines. I still haven't managed to properly test custom built Santa versions, so I can only guarantee that it compiles. Sorry.

@np5 np5 force-pushed the preflight_model_identifier branch from 7107a5b to 45d440b Compare March 15, 2022 12:07
@np5 np5 changed the title Add model identifier to postflight request Add model identifier to preflight request Mar 15, 2022
Copy link
Collaborator

@russellhancox russellhancox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I'll do a quick test once I'm at my desk before approving.

Thanks!

Source/common/SNTSystemInfo.m Outdated Show resolved Hide resolved
@russellhancox russellhancox enabled auto-merge (squash) March 15, 2022 14:19
@russellhancox
Copy link
Collaborator

Just need to rebase onto main and it'll merge automatically. This will then be included in 2022.3, which should be released in the next 1-2 weeks.

@np5 np5 force-pushed the preflight_model_identifier branch from 29f4986 to e8e1b6d Compare March 15, 2022 14:22
@russellhancox russellhancox merged commit 818d3f6 into google:main Mar 15, 2022
@np5 np5 deleted the preflight_model_identifier branch March 15, 2022 14:27
@np5
Copy link
Contributor Author

np5 commented Mar 15, 2022

Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants