Disable layering check for Objective-C #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Objective-C targets in these packages are currently not layering check clean. Disabling layering check ensures that they will continue to build even when we enable layering check for Objective-C within Google. We also need to reenable layering_check on proto_library to avoid internal breakges, due to 1. proto_library still implying cpp for some code paths, and 2. disabling cpp layering check requires being on an allowlist.
russellhancox
approved these changes
Apr 12, 2022
|
Thanks! |
|
Thank you! |
googlewalt
added a commit
to googlewalt/santa
that referenced
this pull request
Apr 18, 2022
Simliar to google#781, but somehow I missed one file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Objective-C targets in these packages are currently not layering
check clean. Disabling layering check ensures that they will continue
to build even when we enable layering check for Objective-C within
Google.
We also need to reenable layering_check on proto_library to avoid
internal breakges, due to 1. proto_library still implying cpp for some
code paths, and 2. disabling cpp layering check requires being on an
allowlist.