Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USB: usbBlockMessage is not being used. #915

Merged
merged 1 commit into from Oct 26, 2022
Merged

USB: usbBlockMessage is not being used. #915

merged 1 commit into from Oct 26, 2022

Conversation

videlanicolas
Copy link
Contributor

@videlanicolas videlanicolas commented Oct 26, 2022 •
edited by pmarkowsky

Remove unused usbBlockMessage attribute from SNTConfigurator.

videlanicolas
videlanicolas commented Oct 26, 2022
View reviewed changes
Copy link
Contributor Author

@videlanicolas videlanicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this property is not being used, a search for it in the code shows no results other than this header file: https://github.com/google/santa/search?q=usbBlockMessage&type=code

@pmarkowsky pmarkowsky self-requested a review October 26, 2022 21:11
pmarkowsky
pmarkowsky approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pmarkowsky pmarkowsky merged commit 3f3de02 into google:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmarkowsky pmarkowsky pmarkowsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@videlanicolas @pmarkowsky