Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use Distance type #19

Closed
optislav opened this issue May 17, 2019 · 2 comments
Closed

Can't use Distance type #19

optislav opened this issue May 17, 2019 · 2 comments

Comments

@optislav
Copy link

Screenshot 2019-05-17 at 14 59 20

@Eyas
Copy link
Collaborator

Eyas commented May 20, 2019

Thanks for the report.

Looks like fixing this needs a bit of a hack; the schema for "Distance" has no indication that it takes this form other than the text of the comment describing it (it's not represented as a data type, etc.). I think part of this is because, in JSON-LD, in theory, string is always a valid value. In practice, I don't know if this is always parsed correctly by crawlers.

For now, I think part of the fix is to get "Quantity" subclasses working right. But it's worth revisiting this and seeing if "string" should be a valid value for all nodes.

@Eyas
Copy link
Collaborator

Eyas commented May 20, 2019

Fixed in #21 and released as schema-dts 0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants