Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in shex module #23

Merged
merged 1 commit into from Dec 15, 2020
Merged

Fix errors in shex module #23

merged 1 commit into from Dec 15, 2020

Conversation

elizusha
Copy link
Contributor

Right now when trying to use schemarama as npm module, the code fails in shex file on two lines with the following errors:

Uncaught ReferenceError: testRange is not defined
    at eval (shex.js:2989)
Uncaught ReferenceError: ShExJison is not defined
    at eval (shex.js:5675)

In the shex repo, these errors are fixed:

  1. https://github.com/shexSpec/shex.js/blob/c5ed1ffbf3e87224050a179d8bcd0db718f9ec3a/packages/shex-parser/shex-parser.js#L3
  2. https://github.com/shexSpec/shex.js/blob/c5ed1ffbf3e87224050a179d8bcd0db718f9ec3a/packages/shex-validator/shex-validator.js#L95

The proper solution is to regenerate shex bundle, but for now the quickest solution is to patch the code directly. This PR makes schemarama works for me.

@Gnomus042 Gnomus042 merged commit 1a4692a into google:main Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants