This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Platformio #14
Merged
Platformio #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
…uino into platformio
…uino into platformio
…uino into platformio Removing old documentation and adding a note in README.md that this branch uses PlatformIO now.
…uino into platformio
|
I think bool GoosciBleGatt::sendData(const char*, int) should use a fixed width int32_t, this probably was a bug in the original Blend implementation but its going to give us inconsistent behavior between platforms. |
Changing GoosciBleGatt::sendData to be use int32_t instead of int so that it is consistent on 8 or 32 bit platforms
…uino into platformio
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please test this branch.