Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.2.7 should be a major release, or at the very least a minor #245

Open
hasezoey opened this issue Aug 15, 2023 · 1 comment
Open

Comments

@hasezoey
Copy link

Release 1.2.7 changes to require engine node >= 18 AND peerDependencies: semantic-release >= 20.1.0, this is (at least in my eyes) a breaking change. Because before nodejs 12 and everything would still work perfectly fine, but now package managers may automatically update to the latest patch version, likely yelling at you and maybe even exiting with a non-0 exit code because it couldnt satisfy the requirements

Consider removing that release and release a 2.0.0 instead, or at the very least a 1.3.0

@hasezoey
Copy link
Author

also just noticed that 1.2.4 and 1.2.1 are also breaking changes, because before (1.2.3) it works with older semantic-release versions (like 19.0.5) but not anymore

1.2.1 (2831e9e) change to use lodash-es, which does not load correctly in semantic-release-replace-plugin with semantic-release 19.0.5 and 1.2.4 also does not work for the same reason (module being converted to ESM)

though the same would apply to @google/semantic-release-replace-plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant