Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Correcting Un-PEP263 encoding definition #35

Closed
alvations opened this issue Mar 14, 2017 · 1 comment
Closed

Correcting Un-PEP263 encoding definition #35

alvations opened this issue Mar 14, 2017 · 1 comment
Assignees
Labels

Comments

@alvations
Copy link

alvations commented Mar 14, 2017

Un-PEP263-like style of encoding definitions should be corrected. The python script's encoding should be magically declared in the 1st/2nd line otherwise it'll not be useful and be treated as a normal comment.

Maybe it should follow how TF's style where the encoding definition comes the license/copyrights, e.g. https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tensorboard/lib/python/http_util_test.py

For details, see http://stackoverflow.com/q/42777847/610569

@alvations alvations changed the title PEP Correcting Un-PEP263 encoding definition Mar 14, 2017
@dennybritz
Copy link
Contributor

Oh, this is good, I had no idea. Will fix :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants