More cached properties to speed up task initialization #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_515095333
branch
2 times, most recently
from
9a58bf0
to
23d0f08
Compare
copybara-service
bot
force-pushed
the
test_515095333
branch
from
23d0f08
to
2332d84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More cached properties to speed up task initialization
See PiperOrigin-RevId: 514750195 (364b494) and PiperOrigin-RevId: 515021299 (ce28ad7) for prior art.
metric_objs are instantiated every task registration, regardless of whether this task (or attribute) is actually used. This instantiation uses slow inspect calls.
This CL makes the metric_objs attribute lazy, thus speeding up module imports for users that use the global TaskRegistry pattern.
The speed-up is difficult to characterize (because API usage is so varied), but in some cases I'm seeing 25% faster runtimes.