Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for Void Linux #59

Closed
wants to merge 1 commit into from
Closed

Conversation

faulesocke
Copy link

See #58 for details

@faulesocke
Copy link
Author

Okay, I think I now have found a better solution. In theory, we could check for all these libraries, but hopefully that's not necessary. @antiagainst I believe this is a working and clean solution now.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@faulesocke faulesocke changed the title WIP: Fix build for Void Linux Fix build for Void Linux Jul 11, 2019
@antiagainst
Copy link
Collaborator

Hey @faulesocke, in order for me to merge this, you'll need to assign the CLA. Also could you rebase against the master? Thanks!

@faulesocke
Copy link
Author

Sorry, I don't have a google account so I can't sign the CLA. Also the CLA looks quite complex which is disproportional to the simplicity of my PR.

@mitchmindtree
Copy link

mitchmindtree commented Jul 29, 2019

I can confirm this patch fixes build issues on Arch Linux as well.

Is there possibly another way to move forward on this? @antiagainst would it possible that you (or someone else who has already signed the CLA) might be able to conveniently come up with a similar solution to this locally and merge a fix yourself? I sympathise with @faulesocke that the CLA is a brutal read for such a simple patch.

@antiagainst
Copy link
Collaborator

69adfd6 should fix this. :)

@antiagainst
Copy link
Collaborator

Thanks again, @faulesocke !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants