Clippy fixes

[filnet]

No description provided.

[filnet]

There are only two clippy warnings left:

warning: very complex type used. Consider factoring parts into `type` definitions
   --> C:\msys64\home\Philippe\rust\shaderc-rs\shaderc-rs\src/lib.rs:645:8
    |
645 |       f: Option<
    |  ________^
646 | |         Box<dyn Fn(&str, IncludeType, &str, usize) -> result::Result<ResolvedInclude, String> + 'a>,
647 | |     >,
    | |_____^
    |
    = note: `#[warn(clippy::type_complexity)]` on by default
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name
   --> C:\msys64\home\Philippe\rust\shaderc-rs\shaderc-rs\src/lib.rs:698:5
    |
698 | /     pub fn clone(&self) -> Option<CompileOptions> {
699 | |         let p = unsafe { scs::shaderc_compile_options_clone(self.raw) };
700 | |         if p.is_null() {
701 | |             None
...   |
704 | |         }
705 | |     }
    | |_____^
    |
    = note: `#[warn(clippy::should_implement_trait)]` on by default
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait

I won't address them as they are trickier to fix.

Edit:

I fixed the type_complexity warning.

Fixing the should_implement_trait would require a breaking change because the current clone function signature has to be changed from

pub fn clone(&self) -> Option<CompileOptions>

to

pub fn clone(&self) -> Self

in order to implement Clone.

[filnet]

Just noticed that clone is broken: the value of include_callback_fn is not cloned and left at None.

[antiagainst]

Awesome! Buildbots should be fixed now. Could you rebase first?

[antiagainst]

Awesome! Buildbots should be fixed now. Could you rebase first?

Actually nvm, I did that. :)