Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation failure due to: SPIRV-Tools removed WebGPU support #1166

Closed
timvpGoogle opened this issue Jan 15, 2021 · 0 comments · Fixed by #1167
Closed

Compilation failure due to: SPIRV-Tools removed WebGPU support #1166

timvpGoogle opened this issue Jan 15, 2021 · 0 comments · Fixed by #1167
Assignees
@zoddicus
Labels
bug deps Roll of the projects dependencies as listed in the DEPS file

Comments

@timvpGoogle
Copy link

SPIRV-Tools removed WebGPU support:
KhronosGroup/SPIRV-Tools#4108

So shaderc no longer compiles due to missing symbols:

    [1344/22848] CXX obj/third_party/shaderc/src/shaderc_util_sources/spirv_tools_wrapper.obj
    FAILED: obj/third_party/shaderc/src/shaderc_util_sources/spirv_tools_wrapper.obj
    C:\b\s\w\ir\cache\goma\client\gomacc.exe ..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.e...(too long)
    ../../third_party/shaderc/src/libshaderc_util/src/spirv_tools_wrapper.cc(149,19): error: no member named 'RegisterVulkanToWebGPUPasses' in 'spvtools::Optimizer'
    optimizer.RegisterVulkanToWebGPUPasses();
@zoddicus zoddicus self-assigned this Jan 18, 2021
@zoddicus zoddicus added bug deps Roll of the projects dependencies as listed in the DEPS file labels Jan 18, 2021
zoddicus added a commit to zoddicus/shaderc that referenced this issue Jan 18, 2021
@zoddicus
Deprecate WebGPU SPIRV support
c25006d 
Fixes google#1166
zoddicus added a commit to zoddicus/shaderc that referenced this issue Jan 18, 2021
@zoddicus
Deprecate WebGPU SPIRV support
6f0c57f 
Roll third_party/spirv-tools/ 1bb80d277..ee39b5db5 (16 commits)

KhronosGroup/SPIRV-Tools@1bb80d2...ee39b5d

$ git log 1bb80d277..ee39b5db5 --date=short --no-merges --format='%ad %ae %s'
2021-01-15 46493288+sfricke-samsung spirv-val: Add Vulkan Addressing Model check (#4107)
2021-01-14 rharrison Remove WebGPU support (#4108)
2021-01-14 46493288+sfricke-samsung spirv-val: Vulkan atomic storage class (#4079)
2021-01-13 jaebaek Avoid integrity check failures caused by propagating line instructions (#4096)
2021-01-13 pierremoreau Linker usability improvements (#4084)
2021-01-12 dj2 Revert "Generate differentiated error codes for buffer oob checking (#4097)" (#4100)
2021-01-11 greg Generate differentiated error codes for buffer oob checking (#4097)
2021-01-07 dneto use std::string::empty() to test for emptiness (#4098)
2021-01-07 46493288+sfricke-samsung spirv-val: Label standalone Vulkan VUID (#4091)
2021-01-06 46493288+sfricke-samsung spirv-val: Add Vulkan decroation VUID (#4090)
2021-01-06 stevenperron Fix binding number calculation in desc sroa (#4095)
2021-01-06 stevenperron Build deps: dump ini from 1.3.5 to 1.3.7 in tools/sva (#4092)
2021-01-06 46493288+sfricke-samsung spirv-val: Add Vulkan FP Mode VUID (#4088)
2021-01-06 46493288+sfricke-samsung spirv-val: Fix Vulkan image sampled check (#4085)
2021-01-06 46493288+sfricke-samsung spirv-val: Add Vulkan ForwardPointer VUID (#4089)
2021-01-06 46493288+sfricke-samsung spirv-val: Add Vulkan ImageTexelPointer format check (#4087)

Created with:
  roll-dep third_party/spirv-tools

Fixes google#1166
@zoddicus zoddicus mentioned this issue Jan 18, 2021
Merged
zoddicus added a commit that referenced this issue Jan 18, 2021
@zoddicus
Deprecate WebGPU SPIRV support (#1167)
73b54fa 
* Deprecate WebGPU SPIRV support

Roll third_party/spirv-tools/ 1bb80d277..ee39b5db5 (16 commits)

KhronosGroup/SPIRV-Tools@1bb80d2...ee39b5d

$ git log 1bb80d277..ee39b5db5 --date=short --no-merges --format='%ad %ae %s'
2021-01-15 46493288+sfricke-samsung spirv-val: Add Vulkan Addressing Model check (#4107)
2021-01-14 rharrison Remove WebGPU support (#4108)
2021-01-14 46493288+sfricke-samsung spirv-val: Vulkan atomic storage class (#4079)
2021-01-13 jaebaek Avoid integrity check failures caused by propagating line instructions (#4096)
2021-01-13 pierremoreau Linker usability improvements (#4084)
2021-01-12 dj2 Revert "Generate differentiated error codes for buffer oob checking (#4097)" (#4100)
2021-01-11 greg Generate differentiated error codes for buffer oob checking (#4097)
2021-01-07 dneto use std::string::empty() to test for emptiness (#4098)
2021-01-07 46493288+sfricke-samsung spirv-val: Label standalone Vulkan VUID (#4091)
2021-01-06 46493288+sfricke-samsung spirv-val: Add Vulkan decroation VUID (#4090)
2021-01-06 stevenperron Fix binding number calculation in desc sroa (#4095)
2021-01-06 stevenperron Build deps: dump ini from 1.3.5 to 1.3.7 in tools/sva (#4092)
2021-01-06 46493288+sfricke-samsung spirv-val: Add Vulkan FP Mode VUID (#4088)
2021-01-06 46493288+sfricke-samsung spirv-val: Fix Vulkan image sampled check (#4085)
2021-01-06 46493288+sfricke-samsung spirv-val: Add Vulkan ForwardPointer VUID (#4089)
2021-01-06 46493288+sfricke-samsung spirv-val: Add Vulkan ImageTexelPointer format check (#4087)

Created with:
  roll-dep third_party/spirv-tools

Fixes #1166

* Retain the public API enums

* Fix implicit fallthrough
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zoddicus zoddicus

Labels
bug deps Roll of the projects dependencies as listed in the DEPS file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate WebGPU SPIRV support zoddicus/shaderc
2 participants
@zoddicus @timvpGoogle