Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ndk build for opcode.inc has cross-ABI dependency #189

Closed
dneto0 opened this issue Apr 1, 2016 · 2 comments
Closed

ndk build for opcode.inc has cross-ABI dependency #189

dneto0 opened this issue Apr 1, 2016 · 2 comments
Assignees

Comments

@dneto0
Copy link
Collaborator

dneto0 commented Apr 1, 2016

From @AWoloszyn comment on #188

"""
I'm willing to let this go, but it does create a fairly strange build dependency, because now for the arm64 build depends on the x86 opcode.inc file.

The only thing I can thing that would solve this is as part of your build do something like copy $(SPVTOOLS_LOCAL_PATH)/source/opcode.cpp -> $(1)/opcode.cpp and change your build to use that opcode.cpp instead of $(SPVTOOLS_LOCAL_PATH)/source/opcode.cpp.

Then arm64 would only depend on arm64 stuff. However that is very complicated, and I don't think will actually make any difference in practice.
"""

@dneto0
Copy link
Collaborator Author

dneto0 commented Apr 1, 2016

I suggested: How about adding a fake-ish target in between:

$(SPVTOOLS_LOCAL_PATH)/source/opcode.cpp : $(1)/opcode.inc.$(APP_ABI)
$(1)/opcode.inc.$(APP_ABI) : $(1)/opcode.inc
     touch $@

@dneto0
Copy link
Collaborator Author

dneto0 commented Apr 1, 2016

I was misunderstanding what the issue was. There is no functional failure with the existing solution. It's just that because the makefile is processed once for each ABI, you'll get more messages and possibly more recompiles than you might expect.
This is not important enough to fix. Closing.

@dneto0 dneto0 closed this as completed Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants