Add rules to build grammar tables in Android.mk for SPIRV-Tools. #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiagainst
force-pushed
the
spvtools-grammar-fix
branch
from
c6f74b2
to
f945548
Compare
|
+1 |
| $(SPVTOOLS_LOCAL_PATH)/source/grammar.json \ | ||
| --opcode-file=$(1)/opcode.inc \ | ||
| --operand-file=$(1)/operand.inc | ||
| @echo "[$(TARGET_ARCH_ABI)] Grammar: opcode.inc & operand.inc <= grammar.json" |
There was a problem hiding this comment.
Don't need quotes here (and it doesn't fit with the rest of the output).
There was a problem hiding this comment.
I'm afraid I cannot remove that because of the <= substring. Aligned them in 81247ec.
There was a problem hiding this comment.
Might need the quotes since the "<" character is special to the shell.
|
+2 |
antiagainst
force-pushed
the
spvtools-grammar-fix
branch
from
81247ec
to
9ede710
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.