Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hang if shader does not end with newline #211

Closed
hypernewbie opened this issue Apr 27, 2016 · 3 comments
Closed

Hang if shader does not end with newline #211

hypernewbie opened this issue Apr 27, 2016 · 3 comments
Assignees
@Qining

Comments

@hypernewbie
Copy link

If input shader does not end with newline, glslc.exe will hang.
@dekimir
Copy link

dekimir commented Apr 27, 2016

Sorry about that; it's a known issue with glslang's TPpContext::tokenize(). It's being looked at...

@dekimir
Copy link

dekimir commented Apr 27, 2016

Actually, there's an upstream fix proposed already: KhronosGroup/glslang#228

@hypernewbie
Copy link
Author

Awesome. closing.

Kangz pushed a commit to Kangz/shaderc that referenced this issue Sep 3, 2019
@kainino0x
Use a descriptor for BindGroupLayout (google#211)
234becf 
* Use a descriptor for BindGroupLayout
* Fix MatchesLambda
* Add WireTests.StructureOfStructureArrayArgument
* Add BindGroupValidationTests.BindGroupLayoutCache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Qining Qining

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dekimir @Qining @hypernewbie