Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abseil as a dep #1329

Merged
merged 1 commit into from
May 26, 2023
Merged

Add abseil as a dep #1329

merged 1 commit into from
May 26, 2023

Conversation

s-perron
Copy link
Collaborator

The latest version of RE2 depends on Abseil. This add Abseil as a dep
for shaderc, and updates RE2 to make sure it works.

This is needed to fix the spirv-tools smoke test.

The latest version of RE2 depends on Abseil. This add Abseil as a dep
for shaderc, and updates RE2 to make sure it works.

This is needed to fix the spirv-tools smoke test.
Copy link
Collaborator

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I'll do the update to add abseil to the known-good.json

@dneto0 dneto0 merged commit efb2de3 into google:main May 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants