Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle includer_ in CompileOptions copy/move constructors #1359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle includer_ in CompileOptions copy/move constructors #1359

wants to merge 1 commit into from

Commits on Aug 5, 2023

  1. Handle includer_ in CompileOptions copy/move constructors 

    Copying CompileOptions() results in a new object with possibly dangling
pointers to the old include callbacks. This patch just clears them,
since includer_ doesn't have a way to clone() it.

Moving CompileOptions() moves options_ but not includer_. This patch
moves includer_ too.
    @pknowles
    pknowles committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    96f96d8 View commit details
    Browse the repository at this point in the history