Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for cmake policy CMP0148 #1382

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Fix for cmake policy CMP0148 #1382

merged 2 commits into from
Dec 1, 2023

Conversation

stuart6854
Copy link
Contributor

FindPythonInterp has been deprecated since CMake 3.12.
This change makes CMake use FindPython for version > 3.12 (otherwise it uses FindPythonInterp).
Tested with CMake 3.27.

https://cmake.org/cmake/help/latest/policy/CMP0148.html

Copy link

google-cla bot commented Nov 30, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dneto0 dneto0 enabled auto-merge (squash) December 1, 2023 15:10
@dneto0 dneto0 disabled auto-merge December 1, 2023 15:20
@dneto0 dneto0 merged commit aaa44b5 into google:main Dec 1, 2023
1 check passed
@dneto0
Copy link
Collaborator

dneto0 commented Dec 1, 2023

Heh. You win a prize. The 1000th GitHub commit in this project. :-)

artdeell pushed a commit to PojavLauncherTeam/shaderc that referenced this pull request Dec 29, 2023
* Fix cmake policy CMP0148

* Fix cmake policy CMP0148 on CMakeLists.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants