-mfmt=bin/c/num to emit binary as it is, numbers or C init list #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,127 @@ | |||
| # Copyright 2015 The Shaderc Authors. All rights reserved. | |||
| |c-init-list |Output SPIRV binary code as a text file containing C-style + | ||
| initializer list. This option is valid when the compilation + | ||
| output is SPIRV binary code. It is not valid to use when the + | ||
| output is not SPIV binary code, like when `-S`, `-E`, `-M`, + |
|
done my review. |
|
Discussed offline. |
Qining
force-pushed
the
compile-to-uint32-array
branch
2 times, most recently
from
d065f90
to
475fd3b
Compare
Qining
changed the title
| |c |Output SPIR-V binary code as a text file containing C-style + | ||
| initializer list. + | ||
| This is just wrapping the output of `num` option with curly | ||
| brakets. |
| ==== `-mfmt=<format>` | ||
|
|
||
| Select output format for compilation output in SPIR-V binary code form. | ||
| Supported options are listed in <<binary-output-format-selection,binary output |
|
Done review. Plus advice to expose binary emission format as public inner class to the FileCompiler, and have a single set-bin-output-format method on FileCompiler. |
|
+2 |
Add command line option: `-mfmt=<fmt>` to select the emission format for SPIR-V binary output. Available formats are `bin` (default): a sequence of binary 32-bitwords in host native endianness; `num` a list of comma-separated hex numbers in text form; `c` a C-style initializer list of hex numbers. `-mfmt=<fmt>` should only be specified when the compilation output is SPIRV binary code. When used with disassembly mode (-S) and preprocessing-only mode (-E), it will result in error and fail the compilation. Note that dumping dependency info as compilation output (-M or -MM) also implies preprocessing-only (-E) and will lead to error. But dumpping dependency info to extra .d file (-MD or -MMD) won't cause error as the compilation output is still SPIRV binary code.
Qining
force-pushed
the
compile-to-uint32-array
branch
from
f70d8d5
to
989394a
Compare
|
Squashed and merged |
Kangz
pushed a commit
to Kangz/shaderc
that referenced
this pull request
Sep 3, 2019
Previously, the renumbering loop would sometimes iterate in the wrong order. To fix this, instead use the binding info already correctly extracted by `ExtractSpirvInfo`. Fixes ComputeCopyStorageBufferTests.BasicTest/D3D12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #214
Add command line option: -masm=c-init-list to emit SPIRV binary code as
a C-style uint32_t array initializer list in the output file.
-masm=c-init-list should only be specified when the compilation output
is SPIRV binary code. When used with disassembly mode (-S) and
preprocessing-only mode (-E), it will result in error and fail the
compilation. Note that dumping dependency info as compilation output (-M
or -MM) also implies preprocessing-only (-E) and will lead to error.
But dumpping dependency info to extra .d file (-MD or -MMD) won't cause
error as the compilation output is still SPIRV binary code.