-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bindings section in Readme #310
Conversation
It's a good idea to reference shaderc binding in this Readme.
Yes, I'm willing to add your binding to the readme once I can make it work. I tried to do "pip install pyshaderc". But it failed. |
Thanks @dneto0 for your interest. I have updated the packaging, can you try again ? If there is an error, can you paste the error. It should work as is. |
I've taken a closer look. I used "pip install --no-clean pyshaderc" to try to install but also avoid cleaning up its build files. This is how it fails:
I see that you have a copy of libshaderc_combined.a in the _cffi_build subdirectory. If this discussion goes on much longer, maybe it should move to an issue on your repo. :-) |
I have created an issue in my repo: realitix/pyshaderc#1 |
I used to have a hard time to compile shaderc and use it via FFI in Rust. I end up feeding CMake with extra configuration to make it work, especially for Windows. Here is the build script: https://github.com/google/shaderc-rs/blob/master/build/build.rs. Hope it is useful in some sense. |
Thanks @antiagainst ! |
realitix@: I would just ship a 32-bit version. Hopefully we don't get shader compilation that requires more than a couple of gigabytes of memory! |
@dneto0 I will not provide the static library, I am going to do like @antiagainst , i will compile the library during the install. |
@dneto0 Can you try again, pyshaderc 1.0.9 should work everywhere now since it compiles shaderc on the fly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add a followup commit to clarify that bindings are maintained by 3rd parties.
Maybe you could add the @antiagainst rust binding too. |
Yes, it would be good to add the rust binding as well. Let's do that as part of a separate PR. FYI. I've been maintaining a known-good branch in shaderc that has a JSON file listing what commits from various projects work together. There's also a simple Python script to read that file and check out the right sources in the right configuration. That can be used to avoid guesswork about what should work with what, and might be helpful to people maintaining 3rd party bindings. I need to describe this in the README |
@dneto0 Good to know the |
This pull request is ok since you have added manually the content. Thanks |
It's a good idea to reference shaderc binding in this Readme.
What do you think about that ?