Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply clang-tidy advice #930

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Apply clang-tidy advice #930

merged 1 commit into from
Dec 5, 2019

Conversation

dneto0
Copy link
Collaborator

@dneto0 dneto0 commented Dec 5, 2019

  • remove useless std::move on a const std::string variable
  • remove redundant return at end of void function

@dneto0
Apply clang-tidy advice
7c8a076 
- remove useless std::move on a const std::string variable
- remove redundant return at end of void function
@dneto0 dneto0 requested a review from sarahM0 December 5, 2019 16:25
@dneto0 dneto0 merged commit 011996b into google:master Dec 5, 2019
andrejnau pushed a commit to andrejnau/shaderc that referenced this pull request Jan 22, 2020
@zoddicus @dneto0
Rolling 4 dependencies (google#728)
4714ba1 
Roll third_party/glslang/ 9db72785b..f9d08a25f (6 commits)

KhronosGroup/glslang@9db7278...f9d08a2

$ git log 9db72785b..f9d08a25f --date=short --no-merges --format='%ad %ae %s'
2019-06-18 cepheus Bump revision.
2019-06-17 cepheus AST/SPV: Fix google#930: translate uvec4 <-> uint64 for SubgroupGeMask et. al.
2019-06-18 cepheus Bump revision.
2019-06-17 cepheus SPV: Add a switch for favoring non-NaN operands in min, max, and clamp.
2019-06-17 cepheus Bump revision.
2019-02-17 jbolz Add Float16/Int8/Int16 capabilities for private variables and function parameters

Roll third_party/googletest/ 176eccfb8..ee32b72e1 (12 commits)

google/googletest@176eccf...ee32b72

$ git log 176eccfb8..ee32b72e1 --date=short --no-merges --format='%ad %ae %s'
2019-06-18 misterg Googletest export
2019-06-17 misterg Googletest export
2019-06-17 misterg Fixing CI break by going to bazel 0.26.1
2019-06-17 misterg Revert "testing, explicitly specify compiler"
2019-06-17 absl-team Googletest export
2019-06-17 misterg Googletest export
2019-06-17 misterg revert travis.yml, irrelevant
2019-06-17 misterg bazel 0.26.1
2019-06-17 misterg bazel 0.26.1
2019-06-17 misterg testing with bazel 0.26.1
2019-06-17 misterg testing with bazel 0.26.1
2019-06-17 misterg testing, explicitly specify compiler

Roll third_party/spirv-cross/ 146dc453b..05ea05509 (2 commits)

KhronosGroup/SPIRV-Cross@146dc45...05ea055

$ git log 146dc453b..05ea05509 --date=short --no-merges --format='%ad %ae %s'
2019-06-18 post Make sure args.msl22 is set in test_shaders.py.
2019-06-18 post MSL: Fix path check in test_shaders.py.

Roll third_party/spirv-tools/ 59983a601..001e823b6 (5 commits)

KhronosGroup/SPIRV-Tools@59983a6...001e823

$ git log 59983a601..001e823b6 --date=short --no-merges --format='%ad %ae %s'
2019-06-18 afdx Add fuzzer pass to obfuscate constants. (#2671)
2019-06-17 33432579+alan-baker Handle volatile memory semantics in upgrade (#2674)
2019-06-17 33432579+alan-baker Validate Volatile memory semantics bit (#2672)
2019-06-17 33432579+alan-baker Disallow stores to UBOs (#2651)
2019-06-17 dneto Another fix uint -> uint32_t (#2676)

Created with:
  roll-dep third_party/effcee third_party/glslang third_party/googletest third_party/re2 third_party/spirv-cross third_party/spirv-headers third_party/spirv-tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahM0 sarahM0 sarahM0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dneto0 @sarahM0