Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Demo] Ads can get shown when playing assets with no ads configured #2943

Closed
DDeis opened this issue Oct 27, 2020 · 1 comment
Closed

[Demo] Ads can get shown when playing assets with no ads configured #2943

DDeis opened this issue Oct 27, 2020 · 1 comment
Assignees
@theodab
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs component: demo page The issue is in the demo page; does not affect production applications status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v3.1

Comments

@DDeis
Copy link
Contributor

DDeis commented Oct 27, 2020

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
3.0.5

Can you reproduce the issue with our latest release version?

Can you reproduce the issue with the latest code from master?

Are you using the demo app or your own custom app?
Demo App

If custom app, can you reproduce the issue using our demo app?

What browser and OS are you using?
Mac OS 10.15.7 - Chrome 86.0.4240.80

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

What did you do?

  1. On the demo homepage
  2. Play Sintel
  3. During the preroll ad, click on Angel One play button
  4. Seek to a position after 00:15 => The player start the midroll from Sintel ad
  5. During the midroll ad, click on Big Buck Bunny: the Dark Truths play button
  6. Seek to the end of the video => The postroll ad from Sintel begins to play

What did you expect to happen?
I expect that when switching asset from one with ads to when without ads, no ads get shown when playing an asset that isn't supposed to have some.

What actually happened?
It seems that ads doesn't get "canceled" when switching assets.
@TheModMaker TheModMaker added component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs type: bug Something isn't working correctly component: demo page The issue is in the demo page; does not affect production applications and removed needs triage labels Oct 27, 2020
@TheModMaker TheModMaker added this to the v3.1 milestone Oct 27, 2020
@theodab theodab self-assigned this Nov 4, 2020
@theodab
Copy link
Collaborator

theodab commented Nov 4, 2020 •
edited

This problem is related to #2869. We aren't disposing of the IMA SDK client-side ad container correctly, so it's sticking around after unloading the player.

@joeyparrish joeyparrish modified the milestones: v3.1, Backlog Nov 11, 2020
@joeyparrish joeyparrish modified the milestones: Backlog, v3.1 Dec 23, 2020
joeyparrish pushed a commit that referenced this issue Dec 23, 2020
@theodab @joeyparrish
Fix(ads): Fix bug w/ configuring UI during CS ads
6074fb6 
Previously, the client-side ad container was put inside the controls
container, which was cleared when the UI was configured. This meant
that re-configuring the UI made client-side ads go away, basically.
This moves client-side ads to go into their own container, which
is never re-made or uprooted, even when the DOM is recreated, in
order to not break the IMA SDK.
This has the side-effect of fixing a bug where client-side ads were
not always cleared upon loading a new asset, and could show up
unexpectedly in future playbacks.

Fixes #2869
Fixes #2943

Change-Id: I3cf67b0b278764c10c6ff2f678316dc9cc85929e
@shaka-project shaka-project locked and limited conversation to collaborators Feb 14, 2021
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@theodab theodab

Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs component: demo page The issue is in the demo page; does not affect production applications status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v3.1
Development

No branches or pull requests
5 participants
@TheModMaker @DDeis @joeyparrish @shaka-bot @theodab