Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing controls by ui.configure() during Ad break the ad #2869

Closed
krychu90 opened this issue Sep 23, 2020 · 1 comment
Closed

Changing controls by ui.configure() during Ad break the ad #2869

krychu90 opened this issue Sep 23, 2020 · 1 comment
Assignees
@theodab
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs component: UI The issue involves the Shaka Player UI status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v3.1

Comments

@krychu90
Copy link

krychu90 commented Sep 23, 2020 •
edited

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
3.0.4

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Yes

Are you using the demo app or your own custom app?
My own

If custom app, can you reproduce the issue using our demo app?
https://jsfiddle.net/w5pxue4h/1/

What browser and OS are you using?
Windows 10, Firefox/Chrome

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
.

What are the manifest and license server URIs?
See demo

What did you do?
Update ui to hide my custom controls when ad is playing.

What did you expect to happen?
Controls are changed, ad still playing.

What actually happened?
Ad is closed
@theodab theodab added component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI and removed needs triage labels Sep 23, 2020
@theodab theodab self-assigned this Sep 23, 2020
@theodab
Copy link
Collaborator

theodab commented Sep 23, 2020

Yeah, this looks like a bug. Thanks for the report!

@shaka-bot shaka-bot added this to the v3.1 milestone Sep 23, 2020
@theodab theodab mentioned this issue Nov 4, 2020
Closed
joeyparrish pushed a commit that referenced this issue Dec 23, 2020
@theodab @joeyparrish
Fix(ads): Fix bug w/ configuring UI during CS ads
6074fb6 
Previously, the client-side ad container was put inside the controls
container, which was cleared when the UI was configured. This meant
that re-configuring the UI made client-side ads go away, basically.
This moves client-side ads to go into their own container, which
is never re-made or uprooted, even when the DOM is recreated, in
order to not break the IMA SDK.
This has the side-effect of fixing a bug where client-side ads were
not always cleared upon loading a new asset, and could show up
unexpectedly in future playbacks.

Fixes #2869
Fixes #2943

Change-Id: I3cf67b0b278764c10c6ff2f678316dc9cc85929e
@shaka-project shaka-project locked and limited conversation to collaborators Feb 14, 2021
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@theodab theodab

Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs component: UI The issue involves the Shaka Player UI status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v3.1
Development

No branches or pull requests
3 participants
@krychu90 @shaka-bot @theodab