Skip to content
This repository has been archived by the owner on Oct 12, 2021. It is now read-only.

Make the cli work with all versions of docker #112

Open
ciera opened this issue Oct 20, 2015 · 4 comments
Open

Make the cli work with all versions of docker #112

ciera opened this issue Oct 20, 2015 · 4 comments
Assignees
Labels

Comments

@ciera
Copy link
Contributor

ciera commented Oct 20, 2015

Many versions of linux come bundled with an old version of docker (<1.7) that is mutually incompatible with later versions. The feature in question is the results from docker inspect. Old versions had a Volumes that mapped string to string. New versions have a Mounts that is an array of objects.

We already have code that works for both of these, we just need to special case based on the docker version.

@ciera ciera added the P1 label Oct 20, 2015
@ciera ciera self-assigned this Oct 20, 2015
@ciera
Copy link
Contributor Author

ciera commented Oct 20, 2015

The change was made in D126.

@ciera
Copy link
Contributor Author

ciera commented Oct 20, 2015

According to this, the change was at docker 1.8. http://www.adelton.com/docs/docker/docker-inspect-volumes-mounts

Still trying to get more precise info so that we can actually determine which version we are using.

@ciera
Copy link
Contributor Author

ciera commented Oct 20, 2015

This implies that they changed it in 1.8.0.
https://github.com/docker/docker/blob/master/CHANGELOG.md#180-2015-08-11

@ciera
Copy link
Contributor Author

ciera commented Oct 22, 2015

Fix submitted; have not been able to verify it yet. Our travis build still fails on this. I think that fails not due to docker versions, but due to running docker-in-docker.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant