Skip to content
This repository has been archived by the owner on Oct 12, 2021. It is now read-only.

Switching directories (up) seems to be broken #72

Closed
ciera opened this issue Jul 14, 2015 · 5 comments
Closed

Switching directories (up) seems to be broken #72

ciera opened this issue Jul 14, 2015 · 5 comments
Assignees
@ciera
Labels
P1

Comments

@ciera
Copy link
Contributor

ciera commented Jul 14, 2015

Cody attempted to run shipshape using the latest version. He ran it first on kythe/go/platforms and it worked. Then he ran it on kythe/go and it fails because it can't cd into the right directory.
@collinw
Copy link
Contributor

collinw commented Jul 14, 2015

This is when running with --stay_up?

@ciera
Copy link
Contributor Author

ciera commented Jul 14, 2015

Yes, which is the default.

On Tue, Jul 14, 2015 at 2:16 PM, Collin Winter notifications@github.com
wrote:

This is when running with --stay_up?

—
Reply to this email directly or view it on GitHub
#72 (comment).

@ciera ciera self-assigned this Jul 14, 2015
@ciera ciera added the P2 label Sep 16, 2015
@ciera ciera added P1 and removed P2 labels Oct 7, 2015
@ciera
Copy link
Contributor Author

ciera commented Oct 13, 2015

So, this is now not broken, only because this is restarting the shipshape container every time....

@supertriceratops
Copy link
Contributor

How about now?

@ciera
Copy link
Contributor Author

ciera commented Oct 15, 2015

It is broken right now. I already mailed a fix, see D141.

ciera added a commit that referenced this issue Oct 16, 2015
@ciera
Fixes switching up directories between runs
c90ebd4 
Summary:
Fixes for #72 (Switching up directories works properly)

The comparison for determining whether to restart the service was incorrect when going from a child directory to a parent directory. It was not restarting in this case, which meant that the parent directory could not be mapped. Instead, we need to restart in this case and reuse the service when going from parent to child.

Reviewers: clconway

Reviewed By: clconway

Differential Revision: https://phabricator-dot-shipshapecode.appspot.com/D141
@ciera ciera closed this as completed Oct 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ciera ciera

Labels
P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ciera @collinw @supertriceratops