Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "expires_at" attribute should also be recalculated on refresh #79

Merged
merged 1 commit into from
Jun 20, 2017

Conversation

chutzimir
Copy link
Contributor

By nil-ing the expires_at attribute, next time expires_at is accessed
through the reader, it will get recalculated.

As it is currently, when refreshing the access_token, the issued_at,
expires_in would get updated, but expires_at may still indicate that the
token has expired.

By nil-ing the expires_at attribute, next time expires_at is accessed
through the reader, it will get recalculated.

As it is currently, when refreshing the access_token, the issued_at,
expires_in would get updated, but expires_at may still indicate that the
token has expired.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@chutzimir
Copy link
Contributor Author

Done, @googlebot,

@googlebot
Copy link

CLAs look good, thanks!

@inopinatus
Copy link

inopinatus commented Oct 28, 2016

I have spent two hours today on "why is it writing a new access token to my credential store on every freaking API call?!"

Now I know why.
Please merge this PR and release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants