Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog buttons appear misaligned #1436

Closed
aaemnnosttv opened this issue Apr 24, 2020 · 5 comments
Closed

Dialog buttons appear misaligned #1436

aaemnnosttv opened this issue Apr 24, 2020 · 5 comments
Labels
Good First Issue Good first issue for new engineers P2 Low priority Type: Enhancement Improvement of an existing feature
Milestone

Comments

@aaemnnosttv
Copy link
Collaborator

aaemnnosttv commented Apr 24, 2020

Feature Description

Currently, all dialog CTA buttons are left-aligned at the bottom. This looks a bit off visually and would be better UX as well if the two were spread apart.

Current Dialogs

image
image

Suggested Layout

image

Justify buttons to the sides to avoid lopsided look, but also make it more difficult to accidentally click the wrong thing.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Dialog CTA buttons should be justified to the sides
  • Additional margin should be added between dialog body and footer

Implementation Brief

  • In assets/sass/vendor/_mdc-dialog.scssmodify the .mdc-dialog__actions class to
    • justify-content: space-between
    • margin:2em 0;
  • Ensure that VRT passes.

Finish and merge: #1453

QA Brief

Changelog entry

  • Improve alignment of dialog buttons.
@aaemnnosttv aaemnnosttv added P2 Low priority Type: Enhancement Improvement of an existing feature Good First Issue Good first issue for new engineers labels Apr 24, 2020
@aaemnnosttv aaemnnosttv self-assigned this Apr 27, 2020
@aaemnnosttv
Copy link
Collaborator Author

This looks like a good start @ryanwelcher - just one request for you:

Can we set the margin using a variable for line-height so that the space is equal to 1 or 2 empty lines of text? Perhaps we can just use em for this.

@ryanwelcher
Copy link
Contributor

@aaemnnosttv sounds good. I've updated the IB accordingly.

@aaemnnosttv
Copy link
Collaborator Author

IB ✅

@aaemnnosttv aaemnnosttv removed their assignment Apr 27, 2020
@jqlee85 jqlee85 self-assigned this Apr 27, 2020
@jqlee85 jqlee85 mentioned this issue Apr 27, 2020
6 tasks
@jqlee85 jqlee85 removed their assignment Apr 27, 2020
@tofumatt tofumatt assigned tofumatt, jqlee85 and felixarntz and unassigned tofumatt and jqlee85 Apr 28, 2020
@tofumatt
Copy link
Collaborator

Code reviewed; just assigned to @aaemnnosttv/@felixarntz to merge. 🙂

@felixarntz felixarntz added this to the Sprint 22 milestone Apr 29, 2020
@felixarntz felixarntz removed their assignment Apr 29, 2020
@cole10up
Copy link

Tested

Confirmed reset button layout:
image

Checked mobile view
image

Confirmed disconnect button layout:
image

Checked mobile view
image

Confirmed buttons and cancel function properly

Passed QA ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good first issue for new engineers P2 Low priority Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

6 participants