-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialog buttons appear misaligned #1436
Labels
Good First Issue
Good first issue for new engineers
P2
Low priority
Type: Enhancement
Improvement of an existing feature
Milestone
Comments
aaemnnosttv
added
P2
Low priority
Type: Enhancement
Improvement of an existing feature
Good First Issue
Good first issue for new engineers
labels
Apr 24, 2020
This looks like a good start @ryanwelcher - just one request for you: Can we set the margin using a variable for line-height so that the space is equal to 1 or 2 empty lines of text? Perhaps we can just use |
@aaemnnosttv sounds good. I've updated the IB accordingly. |
IB ✅ |
Code reviewed; just assigned to @aaemnnosttv/@felixarntz to merge. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Good First Issue
Good first issue for new engineers
P2
Low priority
Type: Enhancement
Improvement of an existing feature
Feature Description
Currently, all dialog CTA buttons are left-aligned at the bottom. This looks a bit off visually and would be better UX as well if the two were spread apart.
Current Dialogs
Suggested Layout
Justify buttons to the sides to avoid lopsided look, but also make it more difficult to accidentally click the wrong thing.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
assets/sass/vendor/_mdc-dialog.scss
modify the.mdc-dialog__actions
class tojustify-content: space-between
margin:2em 0;
Finish and merge: #1453
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: