New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When you don't have enough data, and switch to 7 days and then back to larger data it shows an error that the data isn't available #184
Comments
Related: #447 Potentially this will already fix it. |
Moving this to IB as it doesn't have an estimate |
Let's check if this is still relevant after the latest changes to the date range selector. I prioritized this for the upcoming release since we should fix it if still a problem, but it could be that it already got fixed by now - in that case this should be closed. |
Just posting here to document what I'm finding, as this wasn't very intuitive to me. It looks like this
Isn't properly "reset" when the date range changes, meaning the empty "Last 7 Days" request sets a |
This one was much tougher to track down than implement, so PR is ready and the IB is set to review. Turns out: it was still happening! 😄 |
IB ✅ but the fix needs tweaking - will follow-up in code review. |
Noticed this on my site. I don't have any data from the last 7 days so when I switch to the last 7 days it rightly shows and error. When I switch back to 14, 28 or 90 days the error still displays.
Steps to recreate:
Currently I get:
I expect to get:
Currently I get:
I expect
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
zeroData
in state any time new data is loaded.Changelog entry
QA Brief
sessionStorage
data to test it, ping me and I can send you some privately. The data I have been testing with needs to be anonymised so I don't want to post it here 😄The text was updated successfully, but these errors were encountered: