-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent jumps in All Traffic widget for loading states and when switching tabs #2710
Comments
@eugene-manuilov I've by now already updated the All-Traffic-bug.movSo the problem here is not even between loading and non-loading state, but within loading state a jump happens. Let me know if you can replicate that, or if you see anything else that doesn't look smooth on your end. Maybe the loading circle jump is the only thing we'll need to fix here. |
@felixarntz yeah, seems like the last bit is to adjust the size of the preview block for the user dimensions pie chart. IB is updated. |
IB ✅ |
QA Update: Pass ✅
all-traffic.mov |
When the new All Traffic widget is in any loading state, you'll see brief jumps where the widget briefly is taller than usually. Similar inconsistencies can be noticed when switching tabs when new data needs to be loaded.
It seems that this is partly caused by the charts library, where on the initial render of any chart it uses a taller height for a split-second sometimes. If the problem here is the charts library and we cannot change that behavior, we should try to wrap it with some container that accounts for that jump, to ensure that at least not the overall widget height jumps.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
Test Coverage
Visual Regression Changes
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: