Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change language on banner prompt to activate Idea Hub regarding topics #3912

Closed
aaemnnosttv opened this issue Aug 19, 2021 · 2 comments
Closed
Labels
Module: Idea Hub Google Idea Hub module related issues P1 Medium priority Type: Enhancement Improvement of an existing feature
Milestone

Comments

@aaemnnosttv
Copy link
Collaborator

aaemnnosttv commented Aug 19, 2021

Feature Description

Change language on banner prompt to activate Idea Hub from "relevant to your site's topic" to "relevant to your site's topic(s)"


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The text in the notification which prompts users to set up Idea Hub should be updated to not be specific to a single topic:

    Set up Idea Hub to get topic suggestions based on unanswered searches that match your site’s topics.

Implementation Brief

Test Coverage

  • N/A

Visual Regression Changes

  • N/A

QA Brief

Changelog entry

  • Update the Idea Hub notification text.
@aaemnnosttv aaemnnosttv added P1 Medium priority Type: Enhancement Improvement of an existing feature Module: Idea Hub Google Idea Hub module related issues labels Aug 19, 2021
@tofumatt tofumatt self-assigned this Aug 19, 2021
@tofumatt tofumatt added the Good First Issue Good first issue for new engineers label Aug 19, 2021
@tofumatt tofumatt removed the Good First Issue Good first issue for new engineers label Aug 19, 2021
@tofumatt tofumatt removed their assignment Aug 19, 2021
@aaemnnosttv aaemnnosttv self-assigned this Aug 25, 2021
@aaemnnosttv
Copy link
Collaborator Author

aaemnnosttv commented Aug 25, 2021

to use "topic(s)" instead of "topic".

@tofumatt we decided to use plural only rather than the either/or syntax as mentioned in the ACs.

I'll update the IB+PR accordingly since it's such a tiny change, otherwise IB ✅

@aaemnnosttv aaemnnosttv added this to the Sprint 56 milestone Aug 25, 2021
@aaemnnosttv aaemnnosttv removed their assignment Aug 25, 2021
@wpdarren wpdarren self-assigned this Aug 27, 2021
@wpdarren
Copy link
Collaborator

QA Update: ✅

  • Confirmed that the notification text has been updated to end in "topics" not "topic".
  • Confirmed this on my test site and on Storybook

image

@wpdarren wpdarren removed their assignment Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Idea Hub Google Idea Hub module related issues P1 Medium priority Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

4 participants