Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design differences on widget title and subtitle for Unified Dashboard #4407

Closed
wpdarren opened this issue Nov 25, 2021 · 5 comments
Closed
Labels
P1 Medium priority Rollover Issues which role over to the next sprint Type: Bug Something isn't working UX Issues that require UX input

Comments

@wpdarren
Copy link
Collaborator

wpdarren commented Nov 25, 2021

Bug Description

While QA'ing #4340 I noticed a few observations, which I understand are out of scope for that ticket.

There are a number of differences between the titles/subtitles on the main and entity dashboard and figma designs.

  • Title: the font size, color and weight is different between dashboard and figma designs.
  • Subtitle: the font size and color is different between dashboard and figma designs. It is hard to read currently.
  • The line height between the title and subtitle is different between dashboard and figma designs.
  • The line height between the subtitle and widget is different between dashboard and figma designs.

Looking at Monetization on the main dashboard, there's a larger space between the subtitle and the widget compared with other areas. It might be because I do not have any ad impressions. @techanvil made an observation on what could be the cause here

image


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • There should not be a gap between the Monetization header and its widget context/area
  • As spotted by @techanvil here, AdBlockerWarningWidget should return <WidgetNull /> instead of null to ensure the spacing is correct and an "empty" widget is not rendered

Implementation Brief

Test Coverage

  • No tests should need updating; VRTs might need updating.

QA Brief

  • Spacing on the AdSense dashboard should be in line with other widget context/areas, eg:

Screenshot 2021-11-29 at 14 55 05

Changelog entry

  • Fix visual gap on AdSense dashboard added by adblocker warning widget when no adblocker is detected.
@wpdarren wpdarren added Type: Bug Something isn't working UX Issues that require UX input labels Nov 25, 2021
@tofumatt tofumatt assigned tofumatt and unassigned tofumatt Nov 29, 2021
@eugene-manuilov eugene-manuilov self-assigned this Nov 29, 2021
@eugene-manuilov
Copy link
Collaborator

IB ✔️

@eugene-manuilov eugene-manuilov removed their assignment Nov 29, 2021
@felixarntz felixarntz added the P1 Medium priority label Nov 29, 2021
@kuasha420 kuasha420 self-assigned this Dec 1, 2021
@kuasha420 kuasha420 removed their assignment Dec 1, 2021
@wpdarren
Copy link
Collaborator Author

wpdarren commented Dec 2, 2021

@kuasha420 @tofumatt @felixarntz are we just fixing the gap between the Monetization header and its widget context/area?

Was wondering about the other areas in the ticket, i.e. font sizes, line heights, etc. If these differences to the figma designs are expected please could someone confirm and I can make sure its included in our known issues list because these will be brought up in the bug bash. Thanks!

@kuasha420
Copy link
Contributor

@wpdarren AC/IB doesn't mention changing the font styles, I'd think we can add that to Bug Bash as known issues.

@wpdarren
Copy link
Collaborator Author

wpdarren commented Dec 2, 2021

@kuasha420 yes, I thought that might be the case, I will add as known issues. Thank you for clarifying!

@wpdarren wpdarren self-assigned this Dec 2, 2021
@FlicHollis FlicHollis added the Rollover Issues which role over to the next sprint label Dec 6, 2021
@wpdarren
Copy link
Collaborator Author

wpdarren commented Dec 7, 2021

QA Update: ✅

Verified:

  • Spacing on the AdSense dashboard should be in line with other widget context/areas
  • Checked the widgets on desktop and smaller screen sizes.

image

@wpdarren wpdarren removed their assignment Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority Rollover Issues which role over to the next sprint Type: Bug Something isn't working UX Issues that require UX input
Projects
None yet
Development

No branches or pull requests

7 participants