-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design differences on widget title and subtitle for Unified Dashboard #4407
Comments
IB ✔️ |
@kuasha420 @tofumatt @felixarntz are we just fixing the gap between the Monetization header and its widget context/area? Was wondering about the other areas in the ticket, i.e. font sizes, line heights, etc. If these differences to the figma designs are expected please could someone confirm and I can make sure its included in our known issues list because these will be brought up in the bug bash. Thanks! |
@wpdarren AC/IB doesn't mention changing the font styles, I'd think we can add that to Bug Bash as known issues. |
@kuasha420 yes, I thought that might be the case, I will add as known issues. Thank you for clarifying! |
Bug Description
While QA'ing #4340 I noticed a few observations, which I understand are out of scope for that ticket.
There are a number of differences between the titles/subtitles on the main and entity dashboard and figma designs.
Looking at Monetization on the main dashboard, there's a larger space between the subtitle and the widget compared with other areas. It might be because I do not have any ad impressions. @techanvil made an observation on what could be the cause here
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
AdBlockerWarningWidget
should return<WidgetNull />
instead ofnull
to ensure the spacing is correct and an "empty" widget is not renderedImplementation Brief
site-kit-wp/assets/js/modules/adsense/components/dashboard/AdBlockerWarningWidget.js
Line 39 in a608bcb
<WidgetNull />
to ensure the widget is not rendered when no AdBlocker is detected.Test Coverage
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: