Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Storybook stories related to UA #7842

Open
zutigrm opened this issue Nov 8, 2023 · 4 comments
Open

Remove Storybook stories related to UA #7842

zutigrm opened this issue Nov 8, 2023 · 4 comments
Labels
P2 Low priority QA: Eng Requires specialized QA by an engineer Type: Infrastructure Engineering infrastructure & tooling

Comments

@zutigrm
Copy link
Collaborator

zutigrm commented Nov 8, 2023 •
edited by hussain-t

Feature Description

Some Stories and their VRT reference images should probably be removed. Here is the list of currently spotted ones in the linked comments:
#7582 (comment)
#7582 (comment)
#7582 (comment)
#7582 (comment)
#7582 (comment)
#7582 (comment)
#7582 (comment)
#7582 (comment)
#7582 (comment)

Also stories from common.stories.js and it's usage across other stories, as only common-gGA4.stories.js should be used.

common-gGA4.stories.js should also need some refactoring especially around how dates are used, for more info see this comment, and this one

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • As a part of removing the analytics module in #7843, most of the UA-relevant Storybook stories should have also been removed. However, the remaining Storybook stories in Site Kit should be reviewed to ensure that no other UA-relevant stories exist.

Implementation Brief

  • Wait until #7843 is merged.
  • Remove the following UA Storybook stories if they still exist:
    • stories/module-analytics.stories.js
    • stories/module-analytics-setup.stories.js
    • stories/module-analytics-settings.stories.js
    • stories/module-analytics-components.stories.js
    • assets/js/components/wp-dashboard/common.stories.js
    • assets/js/components/adminbar/common.stories.js
    • assets/js/components/adminbar/AdminBarSessions.stories.js
    • assets/js/components/adminbar/AdminBarUniqueVisitors.stories.js
    • assets/js/components/wp-dashboard/WPDashboardPopularPages.stories.js
    • assets/js/components/wp-dashboard/WPDashboardSessionDuration.stories.js
    • assets/js/components/wp-dashboard/WPDashboardUniqueVisitors.stories.js
    • assets/js/components/wp-dashboard/WPDashboardUniqueVisitorsChart.stories.js
    • assets/js/modules/analytics/components/common/UACutoffWarning.stories.js
    • assets/js/modules/analytics/components/settings/SettingsUACutoffWarning.stories.js
    • assets/js/modules/analytics/components/dashboard/DashboardOverallPageMetricsWidget.stories.js
    • assets/js/modules/analytics/components/setup/SetupFormUA.stories.js
    • assets/js/modules/analytics/components/settings/SettingsView.stories.js
    • assets/js/modules/analytics/components/settings/SettingsForm.stories.js
  • Look for the [Story].scenario in the above files and remove the relevant VRT images from tests/backstop/reference.

Test Coverage

  • No new tests are required for this change.
  • Ensure the Visual Regression Tests pass after removing the stories and their VRT images.

QA Brief

Changelog entry
@zutigrm zutigrm added the Type: Enhancement Improvement of an existing feature label Nov 8, 2023
@techanvil techanvil mentioned this issue Nov 8, 2023
Closed
@zutigrm zutigrm mentioned this issue Nov 13, 2023
Merged
18 tasks
@aaemnnosttv
Copy link
Collaborator

@nfmohit this should be coordinated with the other SAM work.

@aaemnnosttv aaemnnosttv added Type: Infrastructure Engineering infrastructure & tooling and removed Type: Enhancement Improvement of an existing feature labels Nov 28, 2023
@nfmohit nfmohit changed the title Revisit Stories That Used UA and GA4 After Removal of ga4Reporting Flag Remove Storybook stories related to UA Nov 29, 2023
@bethanylang bethanylang added the P1 Medium priority label Nov 29, 2023
@bethanylang bethanylang added the Next Up Issues to prioritize for definition label Dec 12, 2023
@nfmohit nfmohit removed their assignment Dec 23, 2023
@eugene-manuilov eugene-manuilov self-assigned this Jan 2, 2024
@eugene-manuilov
Copy link
Collaborator

AC ✔️

@eugene-manuilov eugene-manuilov removed their assignment Jan 2, 2024
@hussain-t hussain-t self-assigned this Jan 4, 2024
@hussain-t hussain-t mentioned this issue Jan 11, 2024
Merged
18 tasks
@bethanylang bethanylang added P2 Low priority and removed P1 Medium priority labels Jan 12, 2024
@ivonac4 ivonac4 added the QA: Eng Requires specialized QA by an engineer label Jan 16, 2024
@bethanylang bethanylang removed the Next Up Issues to prioritize for definition label Jan 19, 2024
@hussain-t hussain-t removed their assignment Jan 22, 2024
@eugene-manuilov eugene-manuilov self-assigned this Jan 22, 2024
@eugene-manuilov
Copy link
Collaborator

IB ✔️

@eugene-manuilov eugene-manuilov removed their assignment Jan 22, 2024
@bethanylang
Copy link
Collaborator

Noting that the earliest we should work on this is Sprint 124, since we're conducting E2E testing on the initial "MVP" for Singular Analytics Module in Sprint 123 and we don't want to add new code while we're doing that. cc @ivonac4 @aaemnnosttv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Low priority QA: Eng Requires specialized QA by an engineer Type: Infrastructure Engineering infrastructure & tooling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@eugene-manuilov @aaemnnosttv @zutigrm @bethanylang @nfmohit @hussain-t @ivonac4