Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing User Input E2E tests. #7862

Closed
techanvil opened this issue Nov 13, 2023 · 2 comments
Closed

Fix failing User Input E2E tests. #7862

techanvil opened this issue Nov 13, 2023 · 2 comments
Labels
P1 Medium priority Type: Infrastructure Engineering infrastructure & tooling

Comments

@techanvil
Copy link
Collaborator

techanvil commented Nov 13, 2023

Feature Description

The User Input tests in the spec file tests/e2e/specs/user-input-questions.test.js have started failing in develop.

As mentioned here, this has started occurring since upgrading our version of Puppeteer. It would be good to revisit the upgrade to see if any NPM dependencies also needed an update and were missed. Alternatively we could see about updating to a more recent version of Puppeteer, or, if needs be we could revert to the previously used version, as we ended up skipping the failing test that we'd upgraded Puppeteer for anyway.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The User Input E2E tests in tests/e2e/specs/user-input-questions.test.js should pass.

Implementation Brief

Test Coverage

  • No changes

QA Brief

  • See E2E tests passing (WP nightly may still have some stability issues)

Changelog entry

  • N/A
@techanvil techanvil added P1 Medium priority Type: Infrastructure Engineering infrastructure & tooling labels Nov 13, 2023
@zutigrm zutigrm self-assigned this Nov 13, 2023
@techanvil techanvil added the Next Up Issues to prioritize for definition label Nov 13, 2023
@tofumatt tofumatt self-assigned this Nov 14, 2023
@tofumatt
Copy link
Collaborator

IB ✅

I'll review the PR here as well 🙂

@tofumatt
Copy link
Collaborator

QA passes as part of the review, so moving this directly to Approval.

@tofumatt tofumatt removed their assignment Nov 14, 2023
@eclarke1 eclarke1 removed the Next Up Issues to prioritize for definition label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority Type: Infrastructure Engineering infrastructure & tooling
Projects
None yet
Development

No branches or pull requests

5 participants