-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Puppeteer and fix useShowTooltip()
test.
#7812
Conversation
Build files for 2944d7e have been deleted. |
Size Change: -4.26 kB (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
Note to code reviewer: you can assign this issue to @tofumatt, not @techanvil, who made the proof-of-concept PR but didn't work on the test fixes for the issue. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @techanvil + @tofumatt !
I'm seeing some failures around the user-input-questions tests which seem unrelated so we can address in a follow-up. |
Summary
Addresses issue:
Relevant technical choices
I (@tofumatt) tried many things to get this test to work in headless mode, but none worked (see discussion at https://10up.slack.com/archives/CBKKQEBR9/p1699556821212059).
For now we're going to skip the E2E test for this, as it works in interactive mode and in-browser.
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist