Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Puppeteer and fix useShowTooltip() test. #7812

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

techanvil
Copy link
Collaborator

@techanvil techanvil commented Nov 1, 2023

Summary

Addresses issue:

Relevant technical choices

I (@tofumatt) tried many things to get this test to work in headless mode, but none worked (see discussion at https://10up.slack.com/archives/CBKKQEBR9/p1699556821212059).

For now we're going to skip the E2E test for this, as it works in interactive mode and in-browser.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Nov 1, 2023

Build files for 2944d7e have been deleted.

Copy link

github-actions bot commented Nov 1, 2023

Size Change: -4.26 kB (0%)

Total Size: 1.41 MB

Filename Size Change
./dist/assets/css/googlesitekit-admin-css-********************.min.css 51.8 kB +61 B (0%)
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.4 kB +23 B (0%)
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 7.58 kB +6 B (0%)
./dist/assets/js/googlesitekit-activation-********************.js 22.6 kB +40 B (0%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 54.2 kB +21 B (0%)
./dist/assets/js/googlesitekit-adminbar-********************.js 33.4 kB +165 B (0%)
./dist/assets/js/googlesitekit-api-********************.js 9.92 kB +2 B (0%)
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.7 kB -1 B (0%)
./dist/assets/js/googlesitekit-components-gm3-********************.js 10 kB +1 B (0%)
./dist/assets/js/googlesitekit-data-********************.js 2.18 kB -1 B (0%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.17 kB -1 B (0%)
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.09 kB +4 B (0%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 18.2 kB +82 B (0%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 9.28 kB +5 B (0%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 23.4 kB -52 B (0%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 68 kB +62 B (0%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 85 kB +848 B (+1%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 106 kB -1.72 kB (-2%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 76.3 kB -1.47 kB (-2%)
./dist/assets/js/googlesitekit-modules-analytics-********************.js 84.7 kB -3.15 kB (-4%)
./dist/assets/js/googlesitekit-modules-********************.js 21.4 kB -54 B (0%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 21.6 kB +31 B (0%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 64.1 kB +681 B (+1%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 31.1 kB +10 B (0%)
./dist/assets/js/googlesitekit-polyfills-********************.js 379 B -1 B (0%)
./dist/assets/js/googlesitekit-settings-********************.js 48.3 kB +414 B (+1%)
./dist/assets/js/googlesitekit-splash-********************.js 65.6 kB +14 B (0%)
./dist/assets/js/googlesitekit-user-input-********************.js 40.3 kB +24 B (0%)
./dist/assets/js/googlesitekit-vendor-********************.js 316 kB +202 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 32.1 kB +976 B (+3%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 61.7 kB -1.47 kB (-2%)
./dist/assets/js/runtime-********************.js 1.3 kB +1 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/js/29-********************.js 2.8 kB
./dist/assets/js/30-********************.js 2.28 kB
./dist/assets/js/31-********************.js 3.72 kB
./dist/assets/js/32-********************.js 929 B
./dist/assets/js/33-********************.js 888 B
./dist/assets/js/34-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 769 B
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB

compressed-size-action

@tofumatt
Copy link
Collaborator

tofumatt commented Nov 9, 2023

Note to code reviewer: you can assign this issue to @tofumatt, not @techanvil, who made the proof-of-concept PR but didn't work on the test fixes for the issue. 🙂

Copy link
Collaborator

@aaemnnosttv aaemnnosttv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @techanvil + @tofumatt !

@aaemnnosttv
Copy link
Collaborator

I'm seeing some failures around the user-input-questions tests which seem unrelated so we can address in a follow-up.

@aaemnnosttv aaemnnosttv merged commit 8dd35e7 into develop Nov 10, 2023
15 of 18 checks passed
@aaemnnosttv aaemnnosttv deleted the bug/7738-fix-show-tooltip-poc branch November 10, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants