Analytics appearing in zero data state for new analytics property.

[mohitwp]

Bug Description

I set up site kit with analytics a/c property which have data. After that I created new property for the same account. As per QAB when I create new property then Analytics should appear in gathering data state. But, in my test I created 3 new properties but for all of them Analytics appearing in zero data state on main dashboard.

Steps to reproduce

1. Connect Analytics with property having data.
2. Go to Analytics settings.
3. Create new property.
4. Go to Main Dashboard.
5. See that analytics is appearing in zero data state.
6. Expected: Analytics should appear in gathering data state.

Screenshots

Recording.706.mp4

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• When a new Analytics property is created and connected (with no data) after a previous property with data was connected, it should appear in a gathering data state, not a zero data state.

Implementation Brief

• In assets/js/modules/analytics-4/datastore/report.js, after this check:

  site-kit-wp/assets/js/modules/analytics-4/datastore/report.js

  Lines 204 to 206 in ff60aea

  	if ( undefined === propertyCreateTime ) {
  	return undefined;
  	}

  Add a new check if propertyCreateTime is 0 and return false

Test Coverage

• Update assets/js/modules/analytics-4/datastore/report.test.js, add a new test case under isGatheringData to cover that it should return false if propertyCreateTime is 0 - not set yet

QA Brief

• Follow the "Steps to reproduce" above.

Changelog entry

• Fix bug that caused new Analytics properties to appear as "zero data" instead of "gathering data".

[bethanylang]

@nfmohit Just checking in to see if you're able to do some testing on this as discussed in stand-up? Thanks! cc @ivonac4

[nfmohit]

Just co-assigned myself and I will look into this later today, thank you @bethanylang !

[techanvil]

Hi @zutigrm, thanks for drafting the IB. One thing - we generally return undefined from a selector to indicate the state is still loading. In the case where propertyCreateTime is 0 the implication is that is has loaded with its default value.

That being the case it would be preferable to return a defined value e.g. false. However, I do also recognise that we might need to treat this as a special case if we do explicitly need it.

If you've already explored the option of using false, and returning undefined in this scenario is the only viable fix without a more extensive refactor, so be it. I just want to confirm whether that's the case.

[zutigrm]

Hi @techanvil

Basically both are working, idea behind returning undefined was to simulate loading, as when 0 default value is returned, it should wait for the value to be retrieved, instead of returning definitive state.

What do you think?

[techanvil]

Hmmm...

I think that I'd go with returning false if that's an option, because the additional loading of the property is outside of the scope of selectDataAvailability() - all this knows is that the current state is loaded or not, so if the external logic changes we might end up in a perpetual "loading" state even if the data is actually loaded. If there's a clear advantage to taking the "simulated loading" approach then we should go with it, but all things being equal I'd stick with returning a defined value to adhere to our conventions and avoid the potential for an incorrect loading state. If that makes sense?

[zutigrm]

@techanvil Thank you. It does makes sense. IB updated

[techanvil]

Great, thanks @zutigrm. IB LGTM. ✅

[wpdarren]

QA Update: ✅

Verified:

• When a new Analytics property is created and connected (with no data) after a previous property with data was connected, the dashboard appears in a gathering data state, not a zero data state.
• I completed additional testing around the scenario with 2nd admin user to ensure gathering state appeared.
• Also checked that the entity and view only dashboards appeared as gathering state.