New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Settings Section toggle switch variant and hook up the setting to toggle the Audiences Widget Area on/off #8177
Comments
AC ✔️ |
IB ✅ |
Hey @zutigrm, as mentioned on Slack I've added a code organization section to the design doc to help keep us aligned. The upshot is that we should create this new It's also worth noting that the audience settings will only be available if Please can you update the IB accordingly? |
Thanks for the update @zutigrm, IB LGTM! ✅ |
…itors-group Enhance/#8177 - Add the settings section toggle switch for audience segmentation widget area visibility
QA Update: ✅Verified:
|
|
Feature Description
Add the Settings Section toggle switch variant and hook up the setting to toggle the Audiences Widget Area on/off.
See Settings section in the design doc.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
POST audience-settings
endpoint and reflects the current state of the Audiences Widget Area visibility.Implementation Brief
assets/js/modules/analytics-4/components/settings/AudienceSegmentation/SettingsVisitorGroups.js
assets/js/components/settings/SettingsPlugin.js
as a starting pointCheckbox
component withSwitch
componentonChange
callback, save the settings using thesetAudienceSegmentationWidgetHidden
action and check for the value usingisAudienceSegmentationWidgetHidden
action, implemented in 7176,assets/js/components/settings/SettingsAdmin.js
site-kit-wp/assets/js/components/settings/SettingsAdmin.js
Lines 50 to 54 in c173f6c
analytics-4
module is active, usingisModuleActive
selector onCORE_MODULES
datastore, and ifaudienceSegmentation
feature flag is enabled to renderSettingsVisitorGroups
component wrapped with<Cell size={ 12 }>
componentTest Coverage
SettingsVisitorGroups
component, ensuring the switch's actions send the events mentioned in the description/ACsQA Brief
Visitor groups
section with the toggle switch is displayed under theKey Metrics
section.audience-settings
endpoint.audience-settings
when toggling the switch.Changelog entry
The text was updated successfully, but these errors were encountered: