The Enable Auto Updates banner can momentarily flash on page load.

[techanvil]

Bug Description

The Enable Auto Updates banner can momentarily flash on page load. See video below.

Note that this might be a glitch that only occurs for a local development environment, and needs some further investigation.

Steps to reproduce

This was reproducible following these steps. However, it only occurred on my local development environment, I tried on a TasteWP site and the Enable Auto Updates banner stayed visible. Therefore, it would be useful to check if this occurs for other developers and whether it points to an issue that is exclusive to the local environment, or a wider issue.

1. Site up Site Kit and connect Analytics.
2. Disconnect Analytics.
3. See the Enable Auto Updates banner momentarily flash on loading the desktop.

Update: As per @jimmymadon's comment below this is reproducible, at least on a local development environment. Note Jimmy's additional requirement to reproduce this: deleting the auto_update_plugins field from the database.

Screenshots

auto-updates-banner-flash.mp4

Additional Context

• PHP Version: any
• OS: any
• Browser: any
• Plugin Version: any
• Device: Spotted on 1.119.0

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The Enable Auto Updates banner should not momentarily flash on page load.

Implementation Brief

• Update this condition in EnableAutoUpdateBannerNotification to check for isDismissed !== false, ensuring that the widget will render null while isDismissed is still loading (i.e. while it's undefined).

site-kit-wp/assets/js/components/notifications/EnableAutoUpdateBannerNotification/index.js

Lines 144 to 146 in cc9f305

	if ( isDismissed ) {
	return null;
	}

Test Coverage

• Update any failing tests.

QA Brief

This task is a bit hard to test as the issue is caused by a race condition and only happens if the API endpoints load super fast, which is only the case on local.

• Ensure you have autoupdate disables
• With admin role, go to dashboard
• Verify the auto update banner shows up.
• Dismiss the auto update banner.
• Reload the page multiple times and verify the auto update banner does not flash up. Compare to this video The Enable Auto Updates banner can momentarily flash on page load. #8235 (comment)
• Verify the

Changelog entry

• Fix bug that could cause the "Enable automatic updates" banner to appear then disappear briefly when the user has a slow internet connection.

[jimmymadon]

@techanvil Yes, this happens on my local dev environment as well - the banner appears for a while and then disappears. In addition to your Steps to reproduce, I did have to delete the auto_update_plugins field from my database too (to clear the previously saved value for Site Kit).

[techanvil]

Cool, thanks for checking this @jimmymadon! With this being reproducible, I've updated the issue with AC and moved it to IB.

[jimmymadon]

On some further investigation, the banner randomly decided to stay put. To reproduce, I reset site kit again and redid the Steps to reproduce but now, I had to refresh the page in quick succession.

Screen.Recording.2024-02-08.at.17.57.59.mov

[zutigrm]

Unassigning myself, in order not to hold it, as I didn't get a chance to explore it yet, and in favour of another P0 issue with higher priority so I can move that one faster

[zutigrm]

@techanvil I cannot reproduce this, I even tried on the slow 3g network. Banner is stable and fixated on my end all the time:

Are you still being able to reproduce this?

[techanvil]

Hi @zutigrm, I just gave it a try and am still able to reproduce it on my local dev environment. Tested and reproduced in Chrome on both Mac and Linux. It happens less often on the Mac for some reason.

[zutigrm]

I am unassigning myself so someone else who can reproduce it can debug it. I can't replicate it on my end

[aaemnnosttv]

IB ✅

[derweili]

This issue is caused by a race condition.
This happens only if the isDismissed is still loading while hasUpdatePluginCapacity, hasChangePluginAutoUpdatesCapacity and siteKitAutoUpdatesEnabled are resolved.

[mohitwp]

QA Update ✅

• Tested on dev and main environment.
• I'm able to reproduce issue on latest environment.
• Verified on dev and main environment flicker issue is now not reproducible.

Latest -

Recording.829.mp4

Dev -

Recording.828.mp4

</details.