Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only render the Audience Segmentation Setup CTA when Analytics is connected #8876

Open
1 task
techanvil opened this issue Jun 14, 2024 · 2 comments
Open
1 task
Labels
Module: Analytics Google Analytics module related issues P2 Low priority Type: Enhancement Improvement of an existing feature

Comments

@techanvil
Copy link
Collaborator

techanvil commented Jun 14, 2024

Feature Description

This is a small cleanup, as at present the Setup CTA won't actually be displayed when Analytics isn't connected due to its internal check for Analytics data availability on load. However it would be preferable to entirely avoid rendering the component when Analytics is not connected, thus avoiding redundant Analytics store lookups and so forth.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The Audience Segmentation Setup CTA should only be rendered when the Analytics module is connected.

Implementation Brief

  • Include a check for Analytics being connected in the conditions for rendering AudienceSegmentationSetupCTAWidget in DashboardMainApp.

{ audienceSegmentationEnabled && (
<AudienceSegmentationSetupCTAWidget />
) }

Test Coverage

  • No new tests needed.

QA Brief

Changelog entry

@techanvil techanvil added Module: Analytics Google Analytics module related issues P1 Medium priority Type: Enhancement Improvement of an existing feature labels Jun 14, 2024
@techanvil techanvil changed the title Don't render the Audience Segmentation Setup CTA unless Analytics is connected Only render the Audience Segmentation Setup CTA when Analytics is connected Jun 14, 2024
@ivonac4 ivonac4 added the Team M Issues for Squad 2 label Jun 17, 2024
@techanvil techanvil assigned techanvil and unassigned techanvil Jun 18, 2024
@nfmohit nfmohit self-assigned this Jun 23, 2024
@nfmohit
Copy link
Collaborator

nfmohit commented Jun 23, 2024

IB ✅

@nfmohit nfmohit removed their assignment Jun 23, 2024
@binnieshah binnieshah added Team S Issues for Squad 1 Team M Issues for Squad 2 and removed Team M Issues for Squad 2 labels Jun 24, 2024
@techanvil techanvil added P2 Low priority and removed P1 Medium priority labels Jun 26, 2024
@binnieshah binnieshah removed the Team S Issues for Squad 1 label Jun 27, 2024
@techanvil
Copy link
Collaborator Author

Moved to Backlog until we get all the P1 issues done and/or the initial release out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Analytics Google Analytics module related issues P2 Low priority Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

4 participants